pageserver: remove AdjacentVectoredReadBuilder and bump minmimum io_buffer_alignment to 512 #9175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffer_alignment to 512 Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)Flaky tests (7)Postgres 17
Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
677f9a4 at 2024-09-27T15:37:13.458Z :recycle: |
hlinnaka
approved these changes
Sep 27, 2024
arpad-m
approved these changes
Sep 27, 2024
bayandin
pushed a commit
that referenced
this pull request
Sep 29, 2024
…buffer_alignment to 512 (#9175) Part of #8130 ## Problem After deploying neondatabase/infra#1927, we shipped `io_buffer_alignment=512` to all prod region. The `AdjacentVectoredReadBuilder` code path is no longer taken and we are running pageserver unit tests 6 times in the CI. Removing it would reduce the test duration by 30-60s. ## Summary of changes - Remove `AdjacentVectoredReadBuilder` code. - Bump the minimum `io_buffer_alignment` requirement to at least 512 bytes. - Use default `io_buffer_alignment` for Rust unit tests. Signed-off-by: Yuchen Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8130
Problem
After deploying https://github.com/neondatabase/infra/pull/1927, we shipped
io_buffer_alignment=512to all prod region. TheAdjacentVectoredReadBuildercode path is no longer taken and we are running pageserver unit tests 6 times in the CI. Removing it would reduce the test duration by 30-60s.Summary of changes
AdjacentVectoredReadBuildercode.io_buffer_alignmentrequirement to at least 512 bytes.io_buffer_alignmentfor Rust unit tests.Checklist before requesting a review
Checklist before merging